Skip to content

Conversation

@Bentcheesee
Copy link
Contributor

  • Added Crow Pet
  • Added Missed Enchant Books (Crop Fever, Turbo-Rose/Moonflower/Sunflower)
  • Added Praying Mantis Bestiary and loot table (also updated previous pest loot tables to include Jelly)
  • Added new Skymart NPC-Shop recipes
  • Added Moonstone, Sunstone, and Mantid Claw Reforge Stones.
  • Fixed Sunflower Minion to be up to lv12
  • Fixed new Cactus recipe (I would also have included the other ones, but other people did those already)

I will get to the rest of new pest bestiary eventually, as well as rewrite the constants/skymart file eventually. tbh, not sure what it's used for

- Fixed Turbo Wheat being outdated
- Fixed Ender Slayer 6 having the wrong percentage
- Fixed Aqua Affinity still claiming to be obtained from Prismarine Collection
- Fixed Chyme, Sewer Fish, and Gift of Learning having outdated lore
- Added Smooth Red Sandstone to Jade support for Umber
also adding greenhouse blueprint and supplying new cactus green recipe
just a few things that seem to have been missed.

I'll do a rewrite of the skymart file at some point.
forgot to include Crop Fever
@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks already, just the comments

Also could you add parents for the pet and enchants that you added?

- Added parents for Crow Pet, Turbo-Rose/Moonflower/Sunflower, and Crop Fever.
- Added back in old Enchanted Cactus Green recipe.
- Added Firefly Pest bestiary and Loot Table
@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@Bentcheesee Bentcheesee requested a review from jani270 December 16, 2025 06:48
@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also there is a ingame command to refresh the nbt, you dont have to update it manually /firm dev reexportlore id

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@NopoTheGamer
Copy link
Member

unrelated but you really shouldnt be making prs from the master branch

@Bentcheesee Bentcheesee requested a review from jani270 December 16, 2025 13:22
@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to fix the gh actions, otherwise looks good

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@Bentcheesee
Copy link
Contributor Author

unrelated but you really shouldnt be making prs from the master branch

yeah, I'm still learning how to use github as I've never used one of these sites collectively until about a month ago and before hand was kinda just dumping everything without actually paying attention. In the future, yeah, I will start properly using branches and actually paying more attention to what I'm doing

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@Bentcheesee Bentcheesee requested a review from jani270 December 18, 2025 03:28
Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Image

@Bentcheesee
Copy link
Contributor Author

I swear I did those already lmao

did I not press save

@github-actions
Copy link
Contributor

I've detected some problems you might want to take a look at, you can see them as annotations in the files tab.

@jani270
Copy link
Collaborator

jani270 commented Dec 18, 2025

I swear I did those already lmao

did I not press save

nope

Copy link
Collaborator

@jani270 jani270 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did the needed changes myself, hope thats fine for you!

@jani270 jani270 added this pull request to the merge queue Dec 20, 2025
Merged via the queue into NotEnoughUpdates:master with commit 85f2d8c Dec 20, 2025
3 checks passed
@Bentcheesee
Copy link
Contributor Author

Yeah that's fine lol

I haven't had proper access to a PC the last two days, have had the power out and my brain has been on fire (possibly literally as I'm debating if I need to go to the hospital)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants